fix: Tracing errors setting span parent for client calls #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy set Signed-off-by: declark1 <[email protected]>
declark1
requested review from
evaline-ju,
gkumbhat and
mdevino
as code owners
mdevino
approved these changes
Oct 9, 2025
Collaborator
mdevino
left a comment
mdevino
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves errors attempting to set parent span in a context where it is already set. Closes #506.
Changes:
trace_context_from_http_response()andtrace_context_from_grpc_response()as these functions attempt to set the span context and parent span in a context where they are already setValidation